0% · 0 of 0 done

Id
01M1XJZTYTM8VZ58PYTW463913
Assignee
nobody
Estimate
none
Labels
item-26
Body and acceptance criteria

SetOverrideBindingClick onto a secure button, ClearOverrideBindings before it, a Holds(key) reading the override layer back through GetBindingAction, and a record of the displaced binding, at src/Targeting/Switch.lua:74, src/Charge/Icon.lua:275, src/Hover/Cast.lua:194, src/Dungeons/Key.lua:57, src/Marking/Keys.lua:74, src/Buttons/Bars.lua:371 and src/Character/Blizzard.lua:167. The first two match down to the comment above Holds.

The shared piece is the take, not the re-take: ns.Rebind at src/Core/Core.lua:1459 already owns the re-take after UPDATE_BINDINGS. ns.TakeKey(button, key, name) returns the displaced binding and calls ns.Rebind inside itself, which retires seven copies and the three probe entries in scripts/check.sh that name it. src/Buttons/Bars.lua:813 answers the event itself and Core's comment at :1434 allows that; src/Character/Blizzard.lua:200 is Core's mechanism rebuilt beside Core's and goes.

Tickets

Not broken down yet, which reads as 0% rather than as delivered.

Add a task
Comments (0)

Nothing said yet.

Write a task under Taking a key off the client, written eight times.

Up to 72 characters, which is what fits on an index card. A story that does not fit on one is too big.

Cancel

Tab choose Enter go Esc close